[record-hessian] Introduce RecordHessian. #14291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduce record hessian. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
|
Plz try to make same commit message and PR comment
|
|
plz split this PR under 50 lines. |
|
Split codes into core snippets for small PR. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
|
@BLee-bot , plz refer #14285 (comment) It's usually OK with others working with this amount of lines but it's take a quite long time and comments with your PRs. |
seanshpark
reviewed
Nov 4, 2024
| @@ -0,0 +1,45 @@ | |||
| /* | |||
There was a problem hiding this comment.
you can split this file to another PR and then rebase this PR to that PR.
There was a problem hiding this comment.
Ok I'll split this module to another PR and going to proceed to that PR first.
This commit introduce hessian observer. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
This commit introduce record hessian. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Split codes into core snippets for small PR. ONE-DCO-1.0-Signed-off-by: Banseok Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces RecordHessian and HessianObserver.
ONE-DCO-1.0-Signed-off-by: Banseok Lee [email protected]
Related Issue : #13480
Draft PR: #13585