[onert/python] Introduce optimizer API #14543
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces optimizer API. - adam.py : Adam optimizer class - sgd.py : SGB optimizer class ONE-DCO-1.0-Signed-off-by: ragmani <[email protected]>
zetwhite
reviewed
Jan 15, 2025
runtime/onert/api/python/package/experimental/train/optimizer/adam.py
Outdated
Show resolved
Hide resolved
zetwhite
reviewed
Jan 15, 2025
Comment on lines
+5
to
+7
| """ | ||
| Base class for optimizers. Subclasses should implement the `step` method. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| """ | |
| Base class for optimizers. Subclasses should implement the `step` method. | |
| """ | |
| """ | |
| Base class for optimizers. | |
| """ |
Since step() is deleted, this needs to be updated.
There was a problem hiding this comment.
@ragmani But I think this has to be fixed. That's why I didn't approve this PR yet.
zetwhite
reviewed
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces optimizer API.
ONE-DCO-1.0-Signed-off-by: ragmani [email protected]