os/: Add support for CM Test and Jitter test with their respective APIs #6690
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abhinav-s235
commented
Feb 19, 2025
•
abhinav-s235
commented
- Modify existing ist415_cmd() function to support both the tests.
- Develop corresponding APIs to perform these tests.
abhinav-s235
force-pushed
the
touch_selftest
branch
2 times, most recently
from
0142f6d to
de93d06
Compare
ewoodev
reviewed
Feb 25, 2025
os/drivers/input/touchscreen.c
Outdated
Comment on lines
335
to
348
| case TSIOC_CMTEST: | ||
| if (priv->ops && priv->ops->touch_cmtest) { | ||
| ret = priv->ops->touch_cmtest(priv, (int *)arg); | ||
| } else { | ||
| ret = -EINVAL; | ||
| } | ||
| break; | ||
| case TSIOC_JITTERTEST: | ||
| if (priv->ops && priv->ops->touch_jittertest) { | ||
| ret = priv->ops->touch_jittertest(priv, (int *)arg); | ||
| } else { | ||
| ret = -EINVAL; | ||
| } | ||
| break; |
There was a problem hiding this comment.
We already has TSIOC_CMD, How about use TSIOC_CMD??
is it common function for touchscreen?, if not, Please use CMD
There was a problem hiding this comment.
Inorder to use TSIOC_CMD we have to send hardcoded command from test application to distinguish it from other commands because in product_factory branch functions cm_test() and cm_jitter_test() do not accept command from terminal.
- Modify existing ist415_cmd() function to support both the tests. - Develop corresponding APIs to perform these tests.
abhinav-s235
force-pushed
the
touch_selftest
branch
from
de93d06 to
3fe0d5f
Compare
abhinav-s235
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.