Test Linter

.github/workflows/linter.yml

@@ -6,21 +6,20 @@ jobs:
   cpp-linter:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: cpp-linter/cpp-linter-action@v2
+      - uses: actions/checkout@v4
+      - uses: cpp-linter/cpp-linter-action@main
         id: linter
+        continue-on-error: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          style: file
-          # The following value will only update a single comment
-          # in a pull request's thread. Set it to false to disable the comment.
-          # Set it to true to post a new comment (and delete the old comment).
-          # thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
-          thread-comments: ${{ github.event_name == 'push' && 'update' }}
+          style: ''
+          files-changed-only: false
+          ignore: crypto
 
       - name: Fail fast?!
-        if: steps.linter.outputs.checks-failed > 0
-        run: echo "Some files failed the linting checks!"
+        if: steps.linter.outputs.checks-failed != 0
+        run: |
+          echo "some linter checks failed. ${{ steps.linter.outputs.checks-failed }}"
         # for actual deployment
         # run: exit 1

README.md

@@ -3,6 +3,7 @@
 [![Build](https://github.com/samsung/mtower/workflows/Build/badge.svg)](https://github.com/samsung/mtower/actions?query=workflow%3ABuild)
 [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/6108/badge)](https://bestpractices.coreinfrastructure.org/projects/6108)
 [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/Samsung/mTower/badge)](https://api.securityscorecards.dev/projects/github.com/Samsung/mTower)
+[![cpp-linter](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/cpp-linter.yml/badge.svg)](https://github.com/cpp-linter/cpp-linter-action/actions/workflows/cpp-linter.yml)
 [![RepoSize](https://img.shields.io/github/repo-size/samsung/mtower.svg)](https://github.com/samsung/mtower)
 [![Release](https://img.shields.io/github/v/release/samsung/mtower.svg)](https://github.com/samsung/mtower/releases)
 [![LICENSE](https://img.shields.io/github/license/samsung/mtower.svg)](https://github.com/samsung/mtower/blob/master/LICENSE)

tools/ecdsa_keygen.c

@@ -59,7 +59,7 @@
   uint8_t d[32]; /* 256-bits */
 }__attribute__((packed)) ECC_KEY_T;
 
 typedef struct _AES_DATA {
   unsigned char key[AES_KEY_SIZE];
   unsigned char iv[AES_BLOCK_SIZE];
 } AES_DATA;
@@ -75,29 +75,29 @@
 
 /* Private Data. */
 /* All static data definitions appear here. */
-uint32_t key[] =
+const uint32_t key[] =
   { 0x78563412, 0x00000000, 0x00000000, 0x00000000, 0x00000000, 0x00000000,
       0x00000000, 0xefcdac00 };
 
-uint32_t iv[] =
+const uint32_t iv[] =
   { 0x78563412, 0x00000000, 0x00000000, 0xefcdac00 };
 
 /* Public Data. */
 /* All data definitions with global scope appear here. */
 
 /* Public Function Prototypes */
 Message *message_init(int);
 int aes256_init(Message *);
 Message *aes256_encrypt(Message *);
 void aes_cleanup(AES_DATA *);
 void message_cleanup(Message *);
 
 void sha256(unsigned char *data, unsigned int data_len, unsigned char *hash)
 {
   SHA256_CTX sha256;
   SHA256_Init(&sha256);
   SHA256_Update(&sha256, data, data_len);
   SHA256_Final(hash, &sha256);
 }
 
 Message *message_init(int length)
@@ -117,7 +117,7 @@
   //point to new data
   input->aes_settings = aes_info;
   //get rand bytes
   memcpy(input->aes_settings->key, key, AES_KEY_SIZE);
   memcpy(input->aes_settings->iv, iv, AES_KEY_SIZE / 2);
 
   return 0;
@@ -374,7 +374,7 @@
   }
   fclose(fd);
 
-exit:
+// exit:
   BN_free(x);
   BN_free(y);
   EC_GROUP_free(ecgroup);