Improve CI #281
Open
Improve CI #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorosl
force-pushed
the
improve-ci
branch
6 times, most recently
from
f2c7c2b
to
accf52f
Compare
|
Is there any reason to maintain |
|
It is purely for debugging purposes. It tests memory arguments for operations. We can close the bug (or reduce tests) if it is not necessary. Especially if it increases the CI time. |
zherczeg
reviewed
Aug 6, 2024
| @@ -89,8 +89,10 @@ jobs: | |||
| rm $GITHUB_WORKSPACE/test/wasm-spec/core/call_indirect.wast | |||
| $RUNNER --engine="$GITHUB_WORKSPACE/out/clang/x86/walrus" | |||
| $RUNNER --jit --engine="$GITHUB_WORKSPACE/out/clang/x64/walrus" | |||
| $RUNNER --jit --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit | |||
| $RUNNER --no-reg-alloc --engine="$GITHUB_WORKSPACE/out/clang/x64/walrus" | |||
There was a problem hiding this comment.
--no-reg-alloc also enables --jit?
clover2123
reviewed
Aug 6, 2024
Comment on lines
-92
to
+95
| $RUNNER --jit --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit | ||
| $RUNNER --no-reg-alloc --engine="$GITHUB_WORKSPACE/out/clang/x64/walrus" | ||
| $RUNNER --engine="$GITHUB_WORKSPACE/out/pure/x64/walrus" basic-tests wasm-test-core jit | ||
| $RUNNER --jit --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit | ||
| $RUNNER --no-reg-alloc --engine="$GITHUB_WORKSPACE/out/pure/x86/walrus" basic-tests wasm-test-core jit |
There was a problem hiding this comment.
The number of build options increased a lot and seems quite complex.
What about utilizing matrix feature of actions to run each test simply?
(reference of matrix: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/using-a-matrix-for-your-jobs)
vorosl
force-pushed
the
improve-ci
branch
5 times, most recently
from
d205578
to
5527785
Compare
Test with jit-no-reg-alloc Signed-off-by: Laszlo Voros <[email protected]>
zherczeg
requested changes
Aug 21, 2024
| @@ -178,10 +185,18 @@ def main(): | |||
| parser.add_argument('suite', metavar='SUITE', nargs='*', default=sorted(DEFAULT_RUNNERS), | |||
| help='test suite to run (%s; default: %s)' % (', '.join(sorted(RUNNERS.keys())), ' '.join(sorted(DEFAULT_RUNNERS)))) | |||
| parser.add_argument('--jit', action='store_true', help='test with JIT') | |||
| parser.add_argument('--no-reg-alloc', action='store_true', help='test with JIT without register allocation') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with jit-no-reg-alloc