vfn/support: introduce rwlock and convert mutex to rwlock for IOMMU look-up
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess |
|
Awesome stuff! What a Christmas present! |
Add support pthread_rwlock_t to vfn/support like existing mutex support. This patch is a prep patch for the following patches introducing improvement of thread scalability when looking up the IOMMU page table in multiple threads. Signed-off-by: Minwoo Im <[email protected]>
The mapping table managed for IOMMU page table is a skiplist protected by mutex with @map->lock. This has led performance impact with multiple threads looking up the page table at the same time, especially when manipulating PRP or SGL data structures per I/O. Application might optimize their own IOMMU-related paths like they prepare the bulk of memory buffers at the beginning time and map them to IOMMU at that time. After that, they can do I/Os based on pre-mapped memory buffers without inserting or deleting entries from page tables. To improve performance scalability, convert existing mutex @map->lock to read-write lock which leads to great performance on read(look-up)-most scenarios. Signed-off-by: Minwoo Im <[email protected]>
This has been used in nowhere. Signed-off-by: Minwoo Im <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.