chore: address review comments

compiler+runtime/CMakeLists.txt

@@ -144,7 +144,6 @@ add_library(
   jank_lib STATIC
   src/cpp/jank/native_box.cpp
   src/cpp/jank/hash.cpp
-  src/cpp/jank/util/character.cpp
   src/cpp/jank/util/cli.cpp
   src/cpp/jank/util/mapped_file.cpp
   src/cpp/jank/util/scope_exit.cpp

compiler+runtime/include/cpp/jank/runtime/detail/object_util.hpp

@@ -66,6 +66,12 @@ namespace jank
     return make_box<runtime::obj::integer>(i);
   }
 
+  [[gnu::always_inline, gnu::flatten, gnu::hot]]
+  inline auto make_box(char const i)
+  {
+    return make_box<runtime::obj::character>(native_persistent_string(1, i));
+  }
+
   [[gnu::always_inline, gnu::flatten, gnu::hot]]
   inline auto make_box(size_t const i)
   {

compiler+runtime/include/cpp/jank/runtime/obj/character.hpp

@@ -7,12 +7,14 @@ namespace jank::runtime
   template <>
   struct static_object<object_type::character> : gc
   {
-    static constexpr native_bool pointer_free{ true };
+    static constexpr native_bool pointer_free{ false };
 
     static_object() = default;
     static_object(static_object &&) = default;
     static_object(static_object const &) = default;
     static_object(native_persistent_string_view const &);
+    static_object(native_persistent_string const &);
+    static_object(char);
 
     /* behavior::objectable */
     native_bool equal(object const &) const;
@@ -21,6 +23,8 @@ namespace jank::runtime
     native_hash to_hash() const;
 
     object base{ object_type::character };
+
+    /* Holds the litereal form of the character as it's written eg. "\\tab" */
     native_persistent_string data;
   };
 

compiler+runtime/src/cpp/jank/codegen/processor.cpp

@@ -85,7 +85,7 @@ namespace jank::codegen
             {
               return "jank::runtime::obj::character_ptr";
             }
-            return "jank::native_persistent_string";
+            return "jank::runtime::obj::character";
           }
         case jank::runtime::object_type::real:
           {

compiler+runtime/src/cpp/jank/runtime/obj/character.cpp

@@ -1,10 +1,54 @@
 #include <jank/runtime/obj/character.hpp>
-#include <jank/util/character.hpp>
 
 namespace jank::runtime
 {
+
+  static option<char> get_char_from_repr(native_persistent_string const &sv)
+  {
+    if(sv.size() == 2)
+    {
+      return sv[1];
+    }
+    else if(sv == "\\newline")
+    {
+      return '\n';
+    }
+    else if(sv == "\\space")
+    {
+      return ' ';
+    }
+    else if(sv == "\\tab")
+    {
+      return '\t';
+    }
+    else if(sv == "\\backspace")
+    {
+      return '\b';
+    }
+    else if(sv == "\\formfeed")
+    {
+      return '\f';
+    }
+    else if(sv == "\\return")
+    {
+      return '\r';
+    }
+
+    return none;
+  }
+
   obj::character::static_object(native_persistent_string_view const &d)
-    : data{ native_persistent_string(d) }
+    : data{ d }
+  {
+  }
+
+  obj::character::static_object(native_persistent_string const &d)
+    : data{ d }
+  {
+  }
+
+  obj::character::static_object(char ch)
+    : data{ 1, ch }
   {
   }
 
@@ -33,6 +77,6 @@ namespace jank::runtime
 
   native_hash obj::character::to_hash() const
   {
-    return static_cast<native_hash>(util::character::get_char_from_repr(data).unwrap());
+    return static_cast<native_hash>(get_char_from_repr(data).unwrap());
   }
 }

compiler+runtime/test/cpp/jank/read/lex.cpp

@@ -655,7 +655,7 @@ namespace jank::read::lex
         }));
       }
 
-      SUBCASE("character followed by a backticked keyword")
+      SUBCASE("Character followed by a backticked keyword")
       {
         processor p{ R"(\a`:kw)" };
         native_vector<result<token, error>> tokens(p.begin(), p.end());

compiler+runtime/test/cpp/jank/read/parse.cpp

@@ -1,4 +1,3 @@
-#include "jank/type.hpp"
 #include <unistd.h>
 
 #include <jank/read/lex.hpp>