-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updated iOS App support to the Vulkan examples #1119
Conversation
…S_MVK / DVK_USE_PLATFORM_IOS_MVK
Thank you very much for your PR. This is very much appreciated. I don't own any apple devices to test this on, so all I can do is a code review. I will take a look at this, but it may take a few weeks. |
Again thanks for agreeing to look at this. Only commits 31f98f9 and later are different from the other PR. Given your comments above about testing on Apple devices, I have gone ahead and added CI support for iOS so you can at least be assured of build sanity. |
Fixed merge conflicts. Thanks for catching my redundant code for getting Also, it seems that you don't want the benchmarking script. Note it is present in this PR too, so please remove if desired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I can't test this looks fine to me and CI is in place. Aside from a minor nitpick I'll merge once I get green light from @billhollings with regards to copyright.
|
||
#MoltenVK Vulkan Examples | ||
|
||
Copyright (c) 2016-2024 [The Brenwill Workshop Ltd.](http://www.brenwill.com). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to get @billhollings feedback if it's okay to put this into my repo, due to the copyright line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. And as I mentioned before, if @billhollings has concerns about maintaining it I can help out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay.
Yes...any code Brenwill contributes (or has contributed) is open-source, and respects the open-source license of this repo.
Delete benchmark script as per feedback from Sascha Willems
Thank you very much for the confirmation. Merging this now :) |
This PR depends on and includes #1117 due to those dependencies - only the final commits here are new. However, I am submitting this as a separate PR since I am not sure if you want to include iOS in your project. I would be happy to provide support from time-to-time for new updates if you need it. I would be interested in @billhollings reaction and if he would like this added to your repository, or if he has other plans. Most of the original code was his, and credits/copyright remain in place but perhaps dates should be updated.
Similar to before, it is an Xcode project contained within a separate sub-folder (but named apple this time) that depends on the base project. It is like the previous xcode sub-folder, but with documentation and functionality emphasis on iOS and the iOS Simulator. macOS standalone app support is also present but not emphasized. Most users should use the base cmake project in the main folder for macOS.
Details are:
Let me know if you are interested in this and if so, I will do my best to help out. If not, then no worries.
I realize that automated CI support is not implemented at this time, but perhaps could be added.Here is a pic of the bloom example running on the iOS simulator...
![Screenshot 2024-04-21 at 1 26 16 PM](https://private-user-images.githubusercontent.com/82544213/325422489-87beac5b-665f-470f-a7b5-e7331fe0de30.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNzA2MzAsIm5iZiI6MTczOTI3MDMzMCwicGF0aCI6Ii84MjU0NDIxMy8zMjU0MjI0ODktODdiZWFjNWItNjY1Zi00NzBmLWE3YjUtZTczMzFmZTBkZTMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjExVDEwMzg1MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdkNGYzMTExMWQ4NmQ4ZWU3MzFiNWYxNDY3NjVkYWRjOWY1MGJlNjhkYmQ1NDNjYTJiZjJhNzVmN2U4ZmZmMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.KawAEj31uO0JYRgXPkialynSrkzMmwwoXYfXds8HMgs)