Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_downloads_list which is causing save_downloaded_file to fail #1098

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix get_downloads_list which is causing save_downloaded_file to fail #1098

merged 1 commit into from
Jan 3, 2024

Conversation

jameerpathan111
Copy link
Contributor

@jameerpathan111 jameerpathan111 commented Jan 2, 2024 •
edited
Loading

Fix get_downloads_list which is causing save_downloaded_file to fail. Fixed issue and removed some unnecessary code.

tests/foreman/ui/test_rhcloud_inventory.py:209: in test_rh_cloud_inventory_settings
    report_path = session.cloudinventory.download_report(org.name)
../../lib64/python3.11/site-packages/airgun/entities/cloud_inventory.py:43: in download_report
    return self.browser.save_downloaded_file()
../../lib64/python3.11/site-packages/airgun/browser.py:430: in save_downloaded_file
    file_uri = files[0]
E   IndexError: list index out of range

@jameerpathan111 jameerpathan111 added CherryPick PR needs CherryPick to previous branches 6.13.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.14.z 6.15.z labels Jan 2, 2024
@jameerpathan111 jameerpathan111 self-assigned this Jan 2, 2024
@jameerpathan111
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_rhcloud_inventory.py -k test_rh_cloud_inventory_settings

@omkarkhatavkar omkarkhatavkar merged commit b72a45d into SatelliteQE:master Jan 3, 2024
5 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
@jameerpathan111 @web-flow
Fix get_downloads_list which is causing save_downloaded_file to fail (#…
467608e 
…1098)

(cherry picked from commit b72a45d)
@Satellite-QE Satellite-QE mentioned this pull request Jan 3, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
@jameerpathan111 @web-flow
Fix get_downloads_list which is causing save_downloaded_file to fail (#…
9cac379 
…1098)

(cherry picked from commit b72a45d)
@Satellite-QE Satellite-QE mentioned this pull request Jan 3, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Jan 3, 2024
@jameerpathan111 @web-flow
Fix get_downloads_list which is causing save_downloaded_file to fail (#…
291718a 
…1098)

(cherry picked from commit b72a45d)
@Satellite-QE Satellite-QE mentioned this pull request Jan 3, 2024
Merged
omkarkhatavkar pushed a commit that referenced this pull request Jan 4, 2024
@Satellite-QE @jameerpathan111
Fix get_downloads_list which is causing save_downloaded_file to fail (#…
08c7d06 
…1098) (#1100)

(cherry picked from commit b72a45d)

Co-authored-by: Jameer Pathan <[email protected]>
omkarkhatavkar pushed a commit that referenced this pull request Jan 4, 2024
@Satellite-QE @jameerpathan111
Fix get_downloads_list which is causing save_downloaded_file to fail (#…
af7204f 
…1098) (#1101)

(cherry picked from commit b72a45d)

Co-authored-by: Jameer Pathan <[email protected]>
omkarkhatavkar pushed a commit that referenced this pull request Jan 4, 2024
@Satellite-QE @jameerpathan111
Fix get_downloads_list which is causing save_downloaded_file to fail (#…
b6f5a89 
…1098) (#1102)

(cherry picked from commit b72a45d)

Co-authored-by: Jameer Pathan <[email protected]>
damoore044 pushed a commit to damoore044/airgun that referenced this pull request Jan 12, 2024
@jameerpathan111 @damoore044
Fix get_downloads_list which is causing save_downloaded_file to fail (S…
2e59564 
…atelliteQE#1098)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarkhatavkar omkarkhatavkar omkarkhatavkar approved these changes

Assignees

@jameerpathan111 jameerpathan111

Labels
6.13.z 6.14.z 6.15.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jameerpathan111 @omkarkhatavkar