Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ContentView view #1734

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Feb 6, 2025

There were few minor fixes needed for new contentview view and entities.

  • Contentview Views:
  1. version_dropdown = Dropdown(
    locator='.//div[@data-ouia-component-id="cv-version-header-actions-dropdown"]'
    )
    locator was mentioned twice in views which could be confusing.
  2. Fixed lce_selector locator.
  • Contentview Entities:
  1. Renamed version_name variable to version to maintain consistency in the module.
  2. def promote does not handle errors in case incorrect lce or invalid promote happens, added a check for handing and reading the error message.
  3. There is no lce variable in views so updated it to lce_selector.
  4. Updated class PromoteContentViewVersion in views

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches 6.16.z labels Feb 6, 2025
@shweta83 shweta83 requested a review from a team February 6, 2025 11:04
@vijaysawant
Copy link
Contributor

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py -k 'test_positive_end_to_end'

Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, thanks for cleaning up some of the cruft in here.

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 6, 2025
@shweta83
Copy link
Contributor Author

shweta83 commented Feb 7, 2025

The test failing due at content-view-repositories-table which is unrelated to the change.

Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me, please run PRT for test from robottelo PR 17530
Ack, (Wait for PRT to pass)

Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Airgun addition looks good, let's wait for the PRT

Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per PRT being green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants