-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ContentView view #1734
base: master
Are you sure you want to change the base?
Fix ContentView view #1734
Conversation
trigger: test-robottelo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, thanks for cleaning up some of the cruft in here.
The test failing due at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good to me, please run PRT for test from robottelo PR 17530
Ack, (Wait for PRT to pass)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Airgun addition looks good, let's wait for the PRT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved per PRT being green
There were few minor fixes needed for new contentview view and entities.
locator='.//div[@data-ouia-component-id="cv-version-header-actions-dropdown"]'
)
locator was mentioned twice in views which could be confusing.
version_name
variable toversion
to maintain consistency in the module.