Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: unicode argument expected, got 'str' #655

Merged

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Feb 23, 2018

Root cause:

$ python2
Python 2.7.14 (default, Dec 11 2017, 16:08:01) 
[GCC 7.2.1 20170915 (Red Hat 7.2.1-2)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from io import StringIO
>>> StringIO().write('str')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: unicode argument expected, got 'str'
>>> StringIO().write(u'str')
3L

I switched to start using StringIO from io and forgot to add u'str'

@lpramuk lpramuk added the review label Feb 23, 2018
@lpramuk lpramuk self-assigned this Feb 23, 2018
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, Thanks!

@JacobCallahan
Copy link
Member

@lpramuk if you can't get any more reviewers in the next 30mins, I'll check back in and merge this.

Fixes #654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants