Adding a String type token #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpetrace
force-pushed
the
zpetrace/string_token
branch
from
b000b94 to
5e15a6e
Compare
zpetrace
force-pushed
the
zpetrace/string_token
branch
from
5e15a6e to
71afc9e
Compare
ogajduse
approved these changes
Sep 3, 2024
JacobCallahan
approved these changes
Sep 3, 2024
|
Thank you @zpetrace! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team uses string type in docstrings and in the testimony.yml settings and even though everything works as it should, for consistency and to be sure the fields are properly validated I propose to add a String token to the logic.