Additional config files specified on commandline #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are added in-order. cpuid - later IDs replace earlier ones msr - MSRs are added to the end of the MSR list
cmouzaoui
reviewed
Aug 28, 2024
| @@ -26,7 +26,7 @@ pub trait Facter<T: From<u32> + From<bool>> { | |||
| } | |||
|
|
|||
| ///Wraps a bit flag, usually representing if a feature is present or not | |||
| #[derive(Serialize, Deserialize, Debug)] | |||
| #[derive(Serialize, Deserialize, Debug, Clone)] | |||
There was a problem hiding this comment.
at what point do these fields get cloned in this PR?
andrewjj20
commented
Aug 28, 2024
cmouzaoui
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are added in-order.
cpuid - later IDs replace earlier ones
msr - MSRs are added to the end of the MSR list
Also, now any or all of the display sections can be skipped.