Skip to content

Commit

Permalink
Changed default View parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomasGorisse committed Nov 20, 2023
1 parent 4d9f58e commit 71de2f0
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions sceneview/src/main/java/io/github/sceneview/SceneView.kt
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,16 @@ import com.google.android.filament.utils.KTX1Loader
import com.google.android.filament.utils.Manipulator
import com.google.android.filament.utils.Utils
import com.google.ar.sceneform.rendering.ViewAttachmentManager
import dev.romainguy.kotlin.math.Float2
import io.github.sceneview.collision.CollisionSystem
import io.github.sceneview.environment.Environment
import io.github.sceneview.environment.IBLPrefilter
import io.github.sceneview.gesture.CameraGestureDetector
import io.github.sceneview.gesture.GestureDetector
import io.github.sceneview.gesture.HitTestGestureDetector
import io.github.sceneview.gesture.MoveGestureDetector
import io.github.sceneview.gesture.RotateGestureDetector
import io.github.sceneview.gesture.ScaleGestureDetector
import io.github.sceneview.gesture.orbitHomePosition
import io.github.sceneview.gesture.targetPosition
import io.github.sceneview.gesture.transform
Expand Down Expand Up @@ -868,20 +872,16 @@ open class SceneView @JvmOverloads constructor(

fun createView(engine: Engine) =
engine.createView().apply {
// // On mobile, better use lower quality color buffer
// renderQuality = renderQuality.apply {
// hdrColorBuffer = QualityLevel.HIGH
// }
// dynamicResolutionOptions = dynamicResolutionOptions.apply {
// enabled = false
// quality = QualityLevel.MEDIUM
// }
// // FXAA is pretty cheap and helps a lot
// antiAliasing = AntiAliasing.NONE
// // Ambient occlusion is the cheapest effect that adds a lot of quality
// ambientOcclusionOptions = ambientOcclusionOptions.apply {
// enabled = false
// }
dynamicResolutionOptions = dynamicResolutionOptions.apply {
enabled = false
quality = QualityLevel.HIGH
}
// FXAA is pretty cheap and helps a lot
antiAliasing = AntiAliasing.NONE
// ambient occlusion is the cheapest effect that adds a lot of quality
ambientOcclusionOptions = ambientOcclusionOptions.apply {
enabled = true
}
// // Bloom is pretty expensive but adds a fair amount of realism
// bloomOptions = bloomOptions.apply {
// enabled = false
Expand Down

0 comments on commit 71de2f0

Please sign in to comment.