Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/issue 438 modify getting recommended similar perfumes #440

Merged

Conversation

ChoHadam
Copy link
Member

Why:

Closes #438

What's being changed:

Main Changes

  • Modify codes of getting recommended similar perfumes
  • Create test codes of Updating/Reading recommended similar perfumes
    • Integral test code
    • Controller test code
    • Service test code
    • DAO test code
  • Migrate from Promise chains to Async/Await

Other Changes

  • Add some comments
  • Remove unnecessary console outputs
  • Add a constant variable of default opcode value
  • Add env variables into workflows

@ChoHadam ChoHadam requested a review from heesung6701 December 29, 2022 09:26
@ChoHadam ChoHadam self-assigned this Dec 29, 2022
@ChoHadam ChoHadam added the enhancement New feature or request label Dec 29, 2022
@ChoHadam ChoHadam linked an issue Dec 29, 2022 that may be closed by this pull request
@@ -260,34 +260,36 @@ const searchPerfume: RequestHandler = (
* example: 0
* x-swagger-router-controller: Perfume
* */
const updateSimilarPerfumes: RequestHandler = (
const updateSimilarPerfumes: RequestHandler = async (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Async/await이 가독성 더 좋은거같아요
수정 좋아요:)

Copy link
Member

@heesung6701 heesung6701 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD

src/dao/PerfumeDao.ts Outdated Show resolved Hide resolved
@ChoHadam ChoHadam requested a review from heesung6701 January 3, 2023 03:41
@ChoHadam ChoHadam merged commit 99258c7 into dev Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Modify some codes of getting recommended similar perfumes
2 participants