fix(workflows): update version of golangci-lint-action #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
And looking at the result of the action, it seems like is ok now (except for the lint errors) https://github.com/Schrodinger-Hat/Daje/actions/runs/9516686436/job/26233502758?pr=25 |
davideimola
previously approved these changes
Jun 27, 2024
|
@davideimola there is a lint problem with https://github.com/Schrodinger-Hat/Daje/blob/72c6f14761358ecad0559766f6fb7efaadf8c5d1/pkg/cmd/init/init.go#L15 You can find it here: https://github.com/Schrodinger-Hat/Daje/actions/runs/9517315920/job/26235612772?pr=25#step:3:32 Do you know how to solve it? |
Wabri
force-pushed
the
fix/lint
branch
2 times, most recently
from
c0263f7
to
9b5c11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the #24 I got errors on ci https://github.com/Schrodinger-Hat/Daje/actions/runs/9514258617/job/26226081863?pr=24 non related to the things I'm adding, we are using the v2 version of https://github.com/golangci/golangci-lint-action and there is the v6 as latest.