Store configVersion in the job schema #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Junjiequan
previously requested changes
Aug 7, 2024
bpedersen2
reviewed
Sep 2, 2024
…1395) * wip cherry-picking commits * wip: casl for job instances before adding argument with jobConfig * merged cherry-picked commit that splits casl, jobs authorization requires two arguments, the new being the jobConfig property. Casl for jobs instances is restructred to use it in the if statements instead of configuration being part of jobInstance * fix linting * proposals pass tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As seen in issue #1341
Motivation
Since we are now using a global job configuration - instead of job specific - we should only store the configuration version inside each job in the db.
Changes:
job.schemawas updated to only includeconfigVersionjobs.controller:instanceAuthorizationJobCreateand was updated to storeconfigVersioninjobInstanceTests:
Tests should be updated to conform with the new job schema and retrieve the configuration from elsewhere.