Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema selector refactor #45

Merged
merged 8 commits into from
Jul 16, 2024
Merged

Conversation

YooSunYoung
Copy link
Contributor

This one's just cleaning up the previous one.
Like, renaming/separating functions to another module/fixing tests.

Comment on lines 50 to 79
"ingestion_options": {
"dry_run": false,
"schemas_directory": "schemas",
"retrieve_instrument_from": "default",
"instrument_position_in_file_path": 3,
"message_saving_options": {
"message_to_file": true,
"message_file_extension": "message.json",
"message_output": "SOURCE_FOLDER"
},
"file_handling_options": {
"hdf_structure_in_metadata": false,
"hdf_structure_to_file": true,
"hdf_structure_file_extension": ".hdf_structure.json",
"hdf_structure_output": "SOURCE_FOLDER",
"local_output_directory": "data",
"compute_file_stats": true,
"compute_file_hash": true,
"file_hash_algorithm": "blake2b",
"save_file_hash": true,
"hash_file_extension": "b2b",
"ingestor_files_directory": "ingestor"
},
"dataset_options": {
"force_dataset_pid": true,
"dataset_pid_prefix": "20.500.12269",
"use_job_id_as_dataset_id": true,
"beautify_metadata_keys": false,
"metadata_levels_separator": " "
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I separated these to make it easier to find/use/update the options.

@YooSunYoung YooSunYoung marked this pull request as ready for review July 16, 2024 14:45
@YooSunYoung YooSunYoung merged commit e256c53 into schema_selector Jul 16, 2024
3 checks passed
@YooSunYoung YooSunYoung deleted the schema_selector_refactor branch July 16, 2024 14:45
@YooSunYoung YooSunYoung restored the schema_selector_refactor branch July 16, 2024 14:45
@YooSunYoung YooSunYoung deleted the schema_selector_refactor branch July 16, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants