fix: save synapse token in memory instead of mongoDB #320
Conversation
Junjiequan
changed the title
Junjiequan
changed the title
| @@ -28,15 +20,5 @@ describe("UserController (acceptance)", () => { | |||
| .send(credentials) | |||
| .expect(401); | |||
| }); | |||
|
|
|||
| it("should resolve in a jwt token when logging in with the correct credentials", async () => { | |||
There was a problem hiding this comment.
Question. Why was this test removed?
There was a problem hiding this comment.
After refactoring JWT validation is no longer needed so is for the JWT test.
Within this PR synapse credential will be directly passed to loopback from SciCat BE, then loopback will use the credential to login Synapse server and save generated token in the memory.
Junjiequan
changed the title
| } while (true); | ||
| } | ||
|
|
||
| @authenticate("jwt") | ||
| @get("/Logbooks/{name}", { |
There was a problem hiding this comment.
Why are we removing authentication?
There was a problem hiding this comment.
Users whomever are able to see logbook tab and able to click into it should be able to see logbook messages, we already have that permission logic somewhere in the scicat BE and scicat FE. So I figured that JWT auth step is redundant.
As loopback service will be running in a SSH protected VM I don't see open URL would cause any harm to our side.
But one alternative way I think we could do is save synapse token in the scicat BE after first login, then trigger synapse service using token received from header in loopback.
| console.error(err); | ||
| } | ||
| } | ||
| break; | ||
| } while (true); | ||
| } | ||
|
|
||
| @authenticate("jwt") | ||
| @post("/Logbooks/{name}/message", { |
Junjiequan
deleted the
SWAP-3202-scicat-fe-investigate-why-logbook-under-proposal
branch
Description
This PR aims to save synapse token in the memory rather than in mongoDB.
Motivation
Currently loopback saves token in the mongoDB which requires extra user credential verification layers to get the token and does not update token on application restart.
We exclusively use synapse for fetching scichat room messages where user credential verification is unnecessary step and it increases application complexity.
Also we don't want to manually update token everytime when the application restarts, so it is better to save the token in the memory and automatically generate new token on every restart.
Fixes:
Changes:
Tests included/Docs Updated?