Finish dsl src update (reorder functions) #1193
Open
+116
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
commented
Mar 10, 2025
| end | ||
|
|
||
| # When compound species are declared using the "@compound begin ... end" option, get a list | ||
| # of the compound species, and also the expression that creates them. | ||
| function read_compound_option(options) | ||
| function read_compounds_option(options) |
There was a problem hiding this comment.
the option is called compounds, not compound.
TorkelE
commented
Mar 10, 2025
| # Reads the observables options. Outputs an expression for creating the observable variables, | ||
| # a vector containing the observable equations, and a list of all observable symbols (this | ||
| # list contains both those declared separately or inferred from the `@observables` option` input`). | ||
| function read_observed_option(options, all_ivs, us_declared, all_syms; requiredec = false) | ||
| function read_observables_option(options, all_ivs, us_declared, all_syms; requiredec = false) |
There was a problem hiding this comment.
the option is called observables, not observed. This one is a bit annoying as I named the option differently from argument name in the ReactionSystem constructor. At some point we might consider switching the option name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #985. Builds on #1192 (for tests to pass.
Basically does the reordering of the functions in the DSL file (which was not part of the original PR to make it less messy). With one exception (flipping the order of the
get_psexprandget_usexprfunctions, to have the order with which they appear in the file), all changes are to reorder the option handling functions to appear in the same order in which they were called in the main function.Also slightly renames two of these option handling functions, so that their names correspond to the option the handle.