Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import totallength in ForwardDiff extension #1112

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Feb 10, 2025

I think this is necessary and should fix downstream issues I just ran into:

  Got exception outside of a @test
  MethodError: no method matching totallength(::Vector{ForwardDiff.Dual{ForwardDiff.Tag{Pumas.Tag, ForwardDiff.Dual{ForwardDiff.Tag{Pumas.Tag, Float64}, Float64, 2}}, ForwardDiff.Dual{ForwardDiff.Tag{Pumas.Tag, Float64}, Float64, 2}, 1}})
  The function `totallength` exists, but no method is defined for this combination of argument types.
  
  Closest candidates are:
    totallength(::ForwardDiff.Dual)
     @ DiffEqBaseForwardDiffExt ~/.julia/packages/DiffEqBase/DnAEG/ext/DiffEqBaseForwardDiffExt.jl:504

@ChrisRackauckas
Copy link
Member

fuck I bungled the hotfix sorry. I don't know how this wasn't caught in the first set of tests but I tested this locally on an autodiff solve case and we seem good now.

@ChrisRackauckas ChrisRackauckas merged commit 1a870e8 into master Feb 10, 2025
19 of 44 checks passed
@ChrisRackauckas ChrisRackauckas deleted the dw/totallength branch February 10, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants