Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring closures closer to best practices #19

Open
nicholaskl97 opened this issue Mar 1, 2024 · 0 comments
Open

Bring closures closer to best practices #19

nicholaskl97 opened this issue Mar 1, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nicholaskl97
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Lots of functions are passed around in this package, some of which capture variables in a way advised against by the Julia performance tips. Those advise use of let blocks for better performance and type stability. That's probably among the many things that could be done to speed up performance of this library.

Describe the solution you’d like

Check wherever closures are made in this library, such as the NumericalNeuralLyapunovFunctions function, and bring them up to best practices, likely with let blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant