-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various interface changes and minor performance improvements #24
Conversation
…vPDESystem`; made dVdt calculation more efficient in `NumericalNeuralLyapunovFunctions`
…elu" to "rectifier"
… and condensed to one method, with performance improvements
Changes to |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
===========================================
+ Coverage 66.25% 76.63% +10.38%
===========================================
Files 9 10 +1
Lines 243 244 +1
===========================================
+ Hits 161 187 +26
+ Misses 82 57 -25 ☔ View full report in Codecov by Sentry. |
…dified damped SHO and damped pendulum tests for greater code coverage
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Changes
Various interface/performance changes, including:
name
keyword toNeuralLyapunovPDESystem
and removed neural network function output for that function (so now it only outputs aPDESystem
)NumericalNeuralLyapunovFunctions
to its own file and renamed itget_numerical_lyapunov_function
; combined methods into one and changed parameter input (now takesres.u.depvar
instead ofres.u
)relu
keyword torectifier
damped_sho.jl
now usesExponentialDecrease
anddamped_pendulum.jl
now uses a softplus-like rectifier)Additionally, cleaned up
local_Lyapunov
(nowlocal_lyapunov
):