Compatibility with newer versions of NeuralPDE, Lux, ModelingToolkit #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upgraded to Lux v1 and NeuralPDE v5.17. Additionally, changed default sigmoid and rectifier in some places due to incompatibility with Zygote. Some tests broken.
…raining` in tests.
…h` keyword to `AsymptoticDecrease`
…`generate_control_function`
…pendulum example in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
To enable GPU support (in progress), we need to use a newer version of NeuralPDE (and, in turn, Lux and ModelingToolkit), which broke some tests. This fixes those.
Adds support for benchmarking with multiple optimization passes (e.g., two passes at different learning rates or an Adam pass followed by a BFGS pass).
Fixes broken
UnstructuredNeuralLyapunovstructure and addsstrengthkeyword toAsymptoticStabilitydecrease condition (for use in periodic systems).Removes examples of
GridTraining, since they're a bad choice in addition to being broken while I was working on this PR (now fixed SciML/NeuralPDE.jl#910).Replaces DifferentialEquations.jl dependency with OrdinaryDiffEq.jl.