Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.10 maintenance #102

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

ArnoStrouwen
Copy link
Member

No description provided.

@ArnoStrouwen
Copy link
Member Author

New invalidation popped up in 1.10?

@ChrisRackauckas
Copy link
Member

Yeah seems like it. Seems pretty innocuous though so I'd make note of what it is and if it doesn't have an easy fix just move on to the next repo.

@ChrisRackauckas ChrisRackauckas merged commit 9c5878e into SciML:master Dec 29, 2023
7 of 11 checks passed
@ArnoStrouwen ArnoStrouwen deleted the julia1.10 branch December 29, 2023 14:29
@ArnoStrouwen
Copy link
Member Author

I'm pretty inexpererienced with the snoopcompile stack.

Is my interpretation correct that this would have to be fixed upstream at DelimitedFiles?

julia> invalidation_trees(invalidations)
1-element Vector{SnoopCompile.MethodInvalidations}:
 inserting show(io::IO, ::MIME{Symbol("text/tab-separated-values")}, a) @ DelimitedFiles C:\Users\arno\.julia\packages\DelimitedFiles\aGcsu\src\DelimitedFiles.jl:835 invalidated:
   mt_backedges: 1: signature Tuple{typeof(show), IOContext{IOBuffer}, MIME, String} triggered MethodInstance for show(::IOContext{IOBuffer}, ::String, ::String) (0 children)
                 2: signature Tuple{typeof(show), IOContext{IOBuffer}, MIME, Base.BinaryPlatforms.Platform} triggered MethodInstance for show(::IOContext{IOBuffer}, ::String, ::Base.BinaryPlatforms.Platform) (0 children)
                 3: signature Tuple{typeof(show), IOContext{IOBuffer}, MIME, Int64} triggered MethodInstance for show(::IOContext{IOBuffer}, ::String, ::Int64) (0 
children)

julia> uinvalidated(invalidations)
Set{Core.MethodInstance} with 3 elements:
  MethodInstance for show(::IOContext{IOBuffer}, ::String, ::Int64)
  MethodInstance for show(::IOContext{IOBuffer}, ::String, ::String)
  MethodInstance for show(::IOContext{IOBuffer}, ::String, ::Base.BinaryPlatforms.Platform)

(QuasiMonteCarlo) pkg> why DelimitedFiles
  Sobol  DelimitedFiles

@ChrisRackauckas
Copy link
Member

Oh so it's in Sobol.jl then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants