Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 3 arg update_func #206

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[WIP] 3 arg update_func #206

wants to merge 3 commits into from

Conversation

vpuri3
Copy link
Member

@vpuri3 vpuri3 commented Jun 18, 2023

fix #202

Operators should accept a single update_func with two methods A = update_func(u, p, t), and update_func(A, u, p, t) # = nothing. The DEFAULT_UPDATE_FUNC shall return nothing to indicate that no update has taken place.

TO DO

  • remove update_func!
  • add 3 arg DEFAULT_UPDATE_FUNC
  • bump version to 0.4

@codecov
Copy link

codecov bot commented Jun 18, 2023

Codecov Report

Merging #206 (b63bfb2) into master (3e808d1) will decrease coverage by 1.24%.
Report is 3 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   70.08%   68.84%   -1.24%     
==========================================
  Files          10       10              
  Lines        1588     1589       +1     
==========================================
- Hits         1113     1094      -19     
- Misses        475      495      +20     
Files Coverage Δ
src/matrix.jl 63.91% <ø> (-4.13%) ⬇️
src/interface.jl 40.36% <0.00%> (-6.86%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vpuri3 vpuri3 changed the title 3 arg default_update_func [WIP] 3 arg default_update_func Jun 19, 2023
@vpuri3 vpuri3 changed the title [WIP] 3 arg default_update_func [WIP] 3 arg update_func Jun 19, 2023
@gaurav-arya
Copy link
Member

Hey, what's the status of this? It could be good to merge soon-ish to minimize the amount of code in the old style we'll have to adjust

@vpuri3 vpuri3 mentioned this pull request Jan 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop first arg for OOP update_coefficients
2 participants