Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aqua CI #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Aqua CI #230

wants to merge 1 commit into from

Conversation

ArnoStrouwen
Copy link
Member

@ArnoStrouwen ArnoStrouwen commented Dec 29, 2023

This package has quite a few method ambiguities that can get called in practice.
I already tried my hand at resolving some of them.
Things I'm still unsure about:

  • How does opnorm work right now? To me, it seems like the standard way of calling it would result in the ambiguity.
  • What +(::SciMLOperators.NullOperator, ::SciMLOperators.AbstractSciMLScalarOperator) should result in. A matrix operator which is equivalent to a scaled identity matrix?
  • No idea at all about +(::SciMLOperators.AddedOperator, ::SciMLOperators.AbstractSciMLScalarOperator)

https://github.com/SciML/SciMLOperators.jl/actions/runs/7359462846/job/20034274147?pr=230#step:6:300

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (ed52fe4) 68.33% compared to head (4b3eb3a) 13.74%.
Report is 10 commits behind head on master.

Files Patch % Lines
src/basic.jl 0.00% 22 Missing ⚠️
src/func.jl 0.00% 1 Missing ⚠️
src/matrix.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #230       +/-   ##
===========================================
- Coverage   68.33%   13.74%   -54.59%     
===========================================
  Files          10       10               
  Lines        1642     1659       +17     
===========================================
- Hits         1122      228      -894     
- Misses        520     1431      +911     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant