Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Coder to Codec, simplify API #25

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Rename Coder to Codec, simplify API #25

wants to merge 4 commits into from

Conversation

CommanderTvis
Copy link
Collaborator

@CommanderTvis CommanderTvis commented Jul 19, 2021 •
edited
Loading

  1. Rename Coder to Codec.
  2. Delete FunctionSpec.
  3. Rename TransportFunctionClient and TransportFunctionServer to FunctionClient and FunctionServer respectively.
  4. Some other API changes.
  5. Provide JsonCodec and CborCodec implemented with kotlinx-serialization.

@CommanderTvis CommanderTvis requested a review from Unrealf1 July 19, 2021 13:40
@CommanderTvis CommanderTvis added feature A new feature request documentation Improvements or additions to documentation labels Jul 19, 2021
@CommanderTvis CommanderTvis changed the title Rename Coder to `Codec, simplify API Rename Coder to Codec, simplify API Jul 19, 2021
@CommanderTvis CommanderTvis marked this pull request as draft July 19, 2021 13:41
@CommanderTvis CommanderTvis requested review from Unrealf1 and removed request for Unrealf1 July 19, 2021 13:41
@CommanderTvis CommanderTvis marked this pull request as ready for review July 22, 2021 15:07
@CommanderTvis CommanderTvis requested a review from altavir July 22, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Unrealf1 Unrealf1 Awaiting requested review from Unrealf1

@altavir altavir Awaiting requested review from altavir

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation feature A new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@CommanderTvis