Added method to remove unused materials / elements / isotopes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobis
added a commit
to lobis/radiation-transport
that referenced
this pull request
Nov 29, 2021
…to remove excess materials SciProgCentre/gdml.kt#42 improving load speed significantly
|
Thanks a lot. I will review and merge soon. |
altavir
requested changes
Dec 2, 2021
src/commonMain/kotlin/space/kscience/gdml/GdmlMaterialPostProcessor.kt
Outdated
Show resolved
Hide resolved
altavir
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41
Code should work but it is not tested with geometry where material is composed of other materials (only tested when material is composed of multiple elements).
There are a few assertions commented in the test because I couldn't get them to work but if implemented they should provide a decent check.
I also updated the
babyIAXO.gdmlgeometry for a new one with excess materials, in order to use in the test.