-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin ASV - airspeed-velocity/asv#1385 #5756
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5756 +/- ##
==========================================
+ Coverage 89.71% 89.74% +0.02%
==========================================
Files 90 91 +1
Lines 22815 22925 +110
Branches 5438 5462 +24
==========================================
+ Hits 20468 20573 +105
- Misses 1617 1620 +3
- Partials 730 732 +2 ☔ View full report in Codecov by Sentry. |
Performance Benchmark Report: b72fe84Performance shifts
Full benchmark results
Generated by GHA run |
Successful benchmark run demonstrates that this pin is effective |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @trexfeathers!
Note that the upstream bug is a bit spurious, and a better fix is to explicitly put the build project command in the asv configuration. |
@HaoZeke thanks, I was looking into that, until I saw that you were investigating including If that doesn't work out then yeah we can add |
…umpydoc-pre-commit * 'numpydoc-pre-commit' of github.com:tkknight/iris: Update CF standard names to v84. (SciTools#5761) Regrid docs fix (SciTools#5758) Improve ncdata and CF information on "iris heart xarray" page (SciTools#5752) Pin ASV - airspeed-velocity/asv#1385. (SciTools#5756) Normalise units of coordinate bounds (SciTools#5746) Add "Which Regridder?" Documentation (SciTools#5742) Document `Coord.ignore_axis` (SciTools#5744) Disable navidation with keys for docs HTML theme options (SciTools#5747) Shapefile masking (SciTools#5470) [pre-commit.ci] pre-commit autoupdate (SciTools#5739) DOCS: Add whatsnew for ruff pydocstyle compliance (SciTools#5700) update docstring (SciTools#5737) Updated environment lockfiles (SciTools#5738) Consider NaNs equal when comparing cubes (SciTools#5713)
🚀 Pull Request
Description
This avoids a bug in Airspeed Velocity's dependencies: airspeed-velocity/asv#1385
Consult Iris pull request check list