fix: fixed the bug that method CurrentTaskFinished was executed multiple times by multiple threads
#1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… times by multiple threads (Scighost#1083) (Scighost#1082) Signed-off-by: OsakaRuma <[email protected]>
Signed-off-by: OsakaRuma <[email protected]>
This was referenced Sep 8, 2024
Signed-off-by: OsakaRuma <[email protected]>
Signed-off-by: OsakaRuma <[email protected]>
|
很可惜，修改后的代码没能通过测试，一键修复过程完成校验后，无法进入到下载流程。 |
…re were multiple steps of the task when installing the game Signed-off-by: OsakaRuma <[email protected]>
|
抱歉，无法进入下载流程的原因是没有考虑到 |
iamscottxu
changed the title
CurrentTaskFinished was executed multiple times by multiple threads CurrentTaskFinished was executed multiple times by multiple threads
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复了 #1082 和 #1083 提及的bug。
另外，照此方法修改后，（ConcurrentExecuteThreadCount和_concurrentExecuteThreadCount本质上已经没有用处了，如果后续不需要知道当前正在运行的Tasks数量，可将其删除。StartTask会反复执行，还是需要使用ConcurrentExecuteThreadCount判断上一个任务的线程是否已经完全退出）