Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Update About View #5690

Merged
merged 2 commits into from
Nov 15, 2023
Merged

[MS] Update About View #5690

merged 2 commits into from
Nov 15, 2023

Conversation

fabienSvtr
Copy link

  • Update links in About View
  • Update UI according to mockups (About Page & Version in Homepage)

#5592

@fabienSvtr fabienSvtr requested a review from a team as a code owner October 31, 2023 17:41
NicoTuxx
NicoTuxx requested changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@NicoTuxx NicoTuxx left a comment •
edited by fabienSvtr
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple design problems on About page:

  • The 'update' button colors for hover and focus/clicked states create weird effects. (look in the linked video)
  • The links have button appearance (Parsec Cloud, License...) why not, but the 'show changelog' who's behavior is a button one, has a link appearance, this is confusing for a user.
  • The home page modal version has 2 titles, the 'about' and 'Parsec Cloud' just one after each other looks weird. (cf linked image)
  • The home page 'version' button is not centered vertically: the text seems a little higher than the icon. (cf second linked image)
  • The 'show changelog' button open a modal, when it's done in the home page 'about' modal, it should use overlapping modal system to avoid weird undesired overlapping effects.
update-button.mp4

image

@NicoTuxx NicoTuxx linked an issue Nov 3, 2023 that may be closed by this pull request
Update About page #5592
Closed
3 tasks
@fabienSvtr fabienSvtr force-pushed the ms-update-links branch 2 times, most recently from 5ebfa90 to f0ad353 Compare November 13, 2023 06:45
fabienSvstr added 2 commits November 15, 2023 16:08
Update button version Homepage
722083b
Update:
ca31fd0 
• Btn 'update' bug
• Btn Changelog design issue
• Title Parsec Cloud removed
• Overlapped modals
• Align text/icon version
• Update tests
FirelightFlagboy
FirelightFlagboy reviewed Nov 15, 2023
View reviewed changes
client/src/locales/en-US.json
@@ -6,7 +6,7 @@
"projectLink": "https://parsec.cloud",
"projectSources": "https://github.com/Scille/parsec-cloud",
"license": "BUSL-1.1",
"licenseLink": "https://spdx.org/licenses/BUSL-1.1.html",
"licenseLink": "https://github.com/Scille/parsec-cloud/blob/master/LICENSE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use raw link ?

Suggested change
"licenseLink": "https://github.com/Scille/parsec-cloud/blob/master/LICENSE",
"licenseLink": "https://raw.githubusercontent.com/Scille/parsec-cloud/master/LICENSE",

client/src/locales/fr-FR.json
@@ -6,7 +6,7 @@
"projectLink": "https://parsec.cloud",
"projectSources": "https://github.com/Scille/parsec-cloud",
"license": "BUSL-1.1",
"licenseLink": "https://spdx.org/licenses/BUSL-1.1.html",
"licenseLink": "https://github.com/Scille/parsec-cloud/blob/master/LICENSE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use raw link ?

Suggested change
"licenseLink": "https://github.com/Scille/parsec-cloud/blob/master/LICENSE",
"licenseLink": "https://raw.githubusercontent.com/Scille/parsec-cloud/master/LICENSE",

@fabienSvtr fabienSvtr added this pull request to the merge queue Nov 15, 2023
Merged via the queue into master with commit 5bd29e2 Nov 15, 2023
11 checks passed
@fabienSvtr fabienSvtr deleted the ms-update-links branch November 15, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FirelightFlagboy FirelightFlagboy FirelightFlagboy left review comments

@NicoTuxx NicoTuxx NicoTuxx approved these changes

@Max-7 Max-7 Max-7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update About page
4 participants
@fabienSvtr @Max-7 @NicoTuxx @FirelightFlagboy