Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Toast style #5770

Merged
merged 1 commit into from
Dec 20, 2023
Merged

[MS] Toast style #5770

merged 1 commit into from
Dec 20, 2023

Conversation

fabienSvtr
Copy link

@fabienSvtr fabienSvtr commented Nov 12, 2023 •
edited
Loading

Describe your PR

• Edit toast style according to mockups
• The horizontal position of the toast is set depending the --parsec-sidebar-menu-width
• Add a title on each toast and add locales (I added a commit by file to make it clear)

image

Still not working

Will be fixed in #5987
• Animation is still not working because of shadow-root element
• Offset from bottom must be 2rem (Currently, we have a margin inside the toast, which is not properly work when a modal appears)

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description
  • Link any dependent pull request in the description

closes #5733
closes #5934

@fabienSvtr fabienSvtr requested a review from a team as a code owner November 12, 2023 17:32
@fabienSvtr fabienSvtr added the A-Client Area: Parsec desktop application label Nov 12, 2023
@Max-7 Max-7 marked this pull request as draft November 20, 2023 09:31
@fabienSvtr fabienSvtr mentioned this pull request Nov 27, 2023
Closed
15 tasks
@fabienSvtr fabienSvtr marked this pull request as ready for review December 4, 2023 09:30
@fabienSvtr fabienSvtr force-pushed the ms-toast-style branch 2 times, most recently from 014bec3 to 4c952de Compare December 5, 2023 16:07
@fabienSvtr fabienSvtr force-pushed the ms-toast-style branch 6 times, most recently from d905a66 to fb459b7 Compare December 20, 2023 10:13
Max-7
Max-7 requested changes Dec 20, 2023
View reviewed changes
client/src/components/core/ms-modal/MsAlertModal.vue Outdated Show resolved Hide resolved
client/src/services/notificationManager.ts Outdated Show resolved Hide resolved
client/src/services/toastManager.ts Outdated Show resolved Hide resolved
client/src/views/devices/DevicesPage.vue Outdated Show resolved Hide resolved
client/src/views/devices/ExportRecoveryDevicePage.vue Outdated Show resolved Hide resolved
client/src/views/files/FoldersPage.vue Outdated Show resolved Hide resolved
client/src/views/home/UserJoinOrganizationModal.vue Outdated Show resolved Hide resolved
client/src/views/users/ActiveUsersPage.vue Outdated Show resolved Hide resolved
NicoTuxx
NicoTuxx requested changes Dec 20, 2023
View reviewed changes
client/src/components/core/ms-modal/MsAlertModal.vue Outdated Show resolved Hide resolved
client/src/views/files/FoldersPage.vue Outdated Show resolved Hide resolved
client/src/views/users/ActiveUsersPage.vue Outdated Show resolved Hide resolved
client/src/services/toastManager.ts Outdated Show resolved Hide resolved
Toast modifications:
b72af69 
• Add title
• Update style
• Update tests
@fabienSvtr fabienSvtr added this pull request to the merge queue Dec 20, 2023
Merged via the queue into master with commit 37f7f31 Dec 20, 2023
13 checks passed
@fabienSvtr fabienSvtr deleted the ms-toast-style branch December 20, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoTuxx NicoTuxx NicoTuxx approved these changes

@Max-7 Max-7 Max-7 approved these changes

Assignees
No one assigned
Labels
A-Client Area: Parsec desktop application
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update toast style
3 participants
@fabienSvtr @Max-7 @NicoTuxx