Rework docker-testbed workflow
#5785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirelightFlagboy
force-pushed
the
rework-publish-testbed
branch
7 times, most recently
from
47e82e5 to
fd55d92
Compare
mmmarcos
approved these changes
Nov 15, 2023
FirelightFlagboy
force-pushed
the
rework-publish-testbed
branch
4 times, most recently
from
c6ac6f8 to
849e1bf
Compare
FirelightFlagboy
force-pushed
the
rework-publish-testbed
branch
from
849e1bf to
3d1b3ee
Compare
mmmarcos
approved these changes
Nov 15, 2023
FirelightFlagboy
force-pushed
the
rework-publish-testbed
branch
from
67efcd9 to
ef5ca84
Compare
- Use a new format for the image tag:
The new format is `{{ version }}-{{ YYYYMMDD }}.sha.{{ short-sha }}`.
You have a step that summary the pushed image.
- Rename the workflow from `publish-testbed` to `docker-testbed`
To harmonize with the yet to exist workflow to build the docker image
for the parsec backend.
- Prevent concurrency run.
- Use the gihtub action `docker/setup-buildx-action` to setup build-kit
engine for docker, that provide support for the cache system & multi
platforms builds.
- Use the GitHub action `docker/metadata-actions`:
- Generate the GitHub tags for us.
- Handle the image name (would could setup to push to `ghcr.io` &
`docker.io` in the future).
- Use the GitHub action `docker/build-publish-actions`:
- Simplify configuring the docker build phase.
- Leverage the GitHub actions cache.
- Would allow to build for multiple platforms.
- Allow to simplify push the generate image with its multiple tags.
- Rework the test part, mainly split into 3 steps instead of 1.
Co-authored-by: Marcos Medrano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a new format for the image tag:
The new format is
{{ version }}-{{ YYYYMMDD }}.sha.{{ short-sha }}.You have a step that summary the pushed image.
Rename the workflow from
publish-testbedtodocker-testbedTo harmonize with the yet to exist workflow to build the docker image
for the parsec backend.
Prevent concurrency run.
Use the gihtub action
docker/setup-buildx-actionto setup build-kitengine for docker, that provide support for the cache system & multi
platforms builds.
Use the GitHub action
docker/metadata-actions:ghcr.io&docker.ioin the future).Use the GitHub action
docker/build-publish-actions:Rework the test part, mainly split into 3 steps instead of 1.