Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Update organization filter #6164

Merged
merged 1 commit into from
Jan 16, 2024
Merged

[MS] Update organization filter #6164

merged 1 commit into from
Jan 16, 2024

Conversation

fabienSvtr
Copy link

@fabienSvtr fabienSvtr commented Jan 15, 2024

Describe your changes

Before

image

After

image

Checklist

Before you submit this pull request, please make sure to:

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description
  • Link any dependent pull request in the description

closes #6122

@fabienSvtr fabienSvtr requested a review from a team as a code owner January 15, 2024 10:06
@Ironicbay
Copy link
Contributor

Unsure if that's a relevant point since it's a very specific behaviour, but if you open the popover after reducing the window size enough that it will be cropped, its size can grow as big as the window when the latter is stretched

Screen.Recording.2024-01-15.at.11.28.30.mov

@Ironicbay
Copy link
Contributor

The position also shifts when resizing the window
Screenshot 2024-01-15 at 11 31 46

@fabienSvtr
Copy link
Author

fabienSvtr commented Jan 15, 2024

The position also shifts when resizing the window Screenshot 2024-01-15 at 11 31 46

I opened an issue for this: #6166

@fabienSvtr fabienSvtr force-pushed the ms-organization-filter branch from 898d534 to 36a06ee Compare January 15, 2024 12:40
@NicoTuxx NicoTuxx added this pull request to the merge queue Jan 16, 2024
Merged via the queue into master with commit 6349f08 Jan 16, 2024
13 checks passed
@NicoTuxx NicoTuxx deleted the ms-organization-filter branch January 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🦋 Final Touch] Update organization filter
3 participants