Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Fixed homepage with no devices/one device #6171

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Jan 16, 2024

Closes #6170

This fixes multiple issues on the home page:

  1. Create/join buttons when there are no devices work properly
  2. Made it possible to create/join an org with only one device
  3. Displays the create/join button in all cases

To test, in OrganizationListPage in the refreshDeviceList, you can add after the deviceList.value = await listAvailableDevices();:

deviceList.value = []; to check with no devices
deviceList.value = [deviceList.value[0]]; to check with one device

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

@Max-7 Max-7 requested a review from a team as a code owner January 16, 2024 06:19
Copy link

@fabienSvtr fabienSvtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Suggestion: From one organization, the user can see the search bar.
<ms-search-input
:label="$t('HomePage.organizationList.search')"
v-model="searchQuery"
id="ms-search-input"
v-show="deviceList.length > 1" // remove this part
/>

@Max-7 Max-7 force-pushed the ms-fix-homepage-solo-device branch from 28b26bc to 00f8e96 Compare January 16, 2024 11:49
@Max-7 Max-7 added this pull request to the merge queue Jan 16, 2024
Merged via the queue into master with commit b46253e Jan 16, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-fix-homepage-solo-device branch January 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixed new homepage bugs when only one device
2 participants