-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequester with key rotation #6644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
10 times, most recently
from
October 29, 2024 12:08
63b87ca
to
ab64e02
Compare
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
October 30, 2024 09:59
97d99a9
to
495f1ed
Compare
AureliaDolo
reviewed
Oct 30, 2024
server/parsec/components/postgresql/sequester_create_service.py
Outdated
Show resolved
Hide resolved
libparsec/crates/protocol/schema/authenticated_cmds/realm_rotate_key.json5
Show resolved
Hide resolved
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
October 30, 2024 19:04
495f1ed
to
414bde3
Compare
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
November 18, 2024 17:03
414bde3
to
bba4902
Compare
8 tasks
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
2 times, most recently
from
December 17, 2024 15:53
6e00794
to
e6f078f
Compare
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
5 times, most recently
from
January 8, 2025 14:40
70da390
to
a342b1f
Compare
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
January 14, 2025 10:46
3f057de
to
16b84d6
Compare
vxgmichel
approved these changes
Jan 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 14, 2025
…-rotation-based-sequester
…d of encrypting vlobs for them
…_bundle_access` field in `TestbedEventRotateKeyRealm`
…i_v4/anonymous/test_organization_bootstrap.py`
…e/revoke in server
…memory implementation of realm/vlob handling sequester webhooks
…uester service webhooks
…support in realm_rotate_key/vlob_create/vlob_update is missing)
…cording to changes to support key-rotation-based-sequester
…ording to changes to support key-rotation-based-sequester
…rvices` administration API in server
touilleMan
force-pushed
the
sequester-with-key-rotation
branch
from
January 14, 2025 14:34
7dee4d7
to
1c4ff98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the sequester service implementation.
Specifically, we encrypt the keys bundle for sequester services, instead of encrypting each manifest as it's uploaded. It's much better that way, by the way (simpler to implement and more robust).
Yet to be done:
It's not an urgent PR (there's no need for it in the demo, I implemented it because it was quick and allowed me to validate the corrections I was thinking while working on CSPN spec).