Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequester with key rotation #6644

Merged
merged 19 commits into from
Jan 14, 2025
Merged

Sequester with key rotation #6644

merged 19 commits into from
Jan 14, 2025

Conversation

touilleMan
Copy link
Member

@touilleMan touilleMan commented Mar 8, 2024

This PR fix the sequester service implementation.
Specifically, we encrypt the keys bundle for sequester services, instead of encrypting each manifest as it's uploaded. It's much better that way, by the way (simpler to implement and more robust).

Yet to be done:

  • PostgreSQL support
  • add tests for realm_rotate_key
  • fix client protocol tests (since vlob_create/vlob_update/realm_rotate_key commands have changed)
  • rename APIv4 into APIv5 (since backward incompatible change has been done in vlob_create/vlob_update/real_rotate_key)

It's not an urgent PR (there's no need for it in the demo, I implemented it because it was quick and allowed me to validate the corrections I was thinking while working on CSPN spec).

@touilleMan touilleMan requested review from a team as code owners March 8, 2024 09:38
@touilleMan touilleMan marked this pull request as draft March 8, 2024 09:38
@mmmarcos mmmarcos linked an issue Mar 8, 2024 that may be closed by this pull request
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch 10 times, most recently from 63b87ca to ab64e02 Compare October 29, 2024 12:08
@touilleMan touilleMan marked this pull request as ready for review October 29, 2024 15:11
@touilleMan touilleMan requested a review from a team as a code owner October 29, 2024 15:11
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch from 97d99a9 to 495f1ed Compare October 30, 2024 09:59
@touilleMan touilleMan linked an issue Oct 30, 2024 that may be closed by this pull request
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch from 495f1ed to 414bde3 Compare October 30, 2024 19:04
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch from 414bde3 to bba4902 Compare November 18, 2024 17:03
@mmmarcos mmmarcos linked an issue Nov 29, 2024 that may be closed by this pull request
8 tasks
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch 2 times, most recently from 6e00794 to e6f078f Compare December 17, 2024 15:53
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch 5 times, most recently from 70da390 to a342b1f Compare January 8, 2025 14:40
@touilleMan touilleMan added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 14, 2025
…_bundle_access` field in `TestbedEventRotateKeyRealm`
…i_v4/anonymous/test_organization_bootstrap.py`
…memory implementation of realm/vlob handling sequester webhooks
…support in realm_rotate_key/vlob_create/vlob_update is missing)
…cording to changes to support key-rotation-based-sequester
…ording to changes to support key-rotation-based-sequester
@touilleMan touilleMan force-pushed the sequester-with-key-rotation branch from 7dee4d7 to 1c4ff98 Compare January 14, 2025 14:34
@touilleMan touilleMan enabled auto-merge January 14, 2025 16:12
@touilleMan touilleMan added this pull request to the merge queue Jan 14, 2025
Merged via the queue into master with commit dbf147d Jan 14, 2025
15 checks passed
@touilleMan touilleMan deleted the sequester-with-key-rotation branch January 14, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants