[MS] Workspace history #8743
Merged
[MS] Workspace history #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-7
force-pushed
the
ms-workspace-history
branch
3 times, most recently
from
f0e7b91 to
68f042c
Compare
Merged
Max-7
force-pushed
the
ms-workspace-history
branch
3 times, most recently
from
f89a963 to
a999559
Compare
Max-7
force-pushed
the
ms-workspace-history
branch
from
9c86f7f to
d5e30f7
Compare
Max-7
force-pushed
the
ms-workspace-history
branch
4 times, most recently
from
60caa71 to
fd34313
Compare
mmmarcos
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
I've performed some quick tests and it seems to be working OK. IMO this feature needs some UI/UX tweaking, but it is probably better to do that in another PR (also to take the time to use this feature).
Just some comments on the wording.
I did not review any ts/vue file, so better wait for other approvals before merge.
Max-7
force-pushed
the
ms-workspace-history
branch
from
25f1e69 to
efcbf4b
Compare
NicoTuxx
requested changes
Oct 30, 2024
NicoTuxx
approved these changes
Oct 30, 2024
Max-7
force-pushed
the
ms-workspace-history
branch
4 times, most recently
from
24b8dca to
f9f7c72
Compare
Co-authored-by: fabienSvstr <[email protected]>
Co-authored-by: Marcos Medrano <[email protected]>
Co-authored-by: NicoTuxx <[email protected]>
Max-7
force-pushed
the
ms-workspace-history
branch
from
f9f7c72 to
a350b78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8663
Waiting for #8662