Ms-file-viewer-bottombar #8965
Ms-file-viewer-bottombar #8965
Conversation
| handler: () => void; | ||
| } | ||
|
|
||
| defineProps({ |
There was a problem hiding this comment.
defineProps<{
actions: Array<FileViewerAction>;
}>();
should work, why the extra steps?
client/src/parsec/mock_generator.ts
Outdated
| @@ -117,7 +117,7 @@ export async function generateFolder( | |||
| export async function generateEntries( | |||
| basePath: FsPath, | |||
| folderCount = 2, | |||
| fileCount = 2, | |||
| fileCount = 10, | |||
There was a problem hiding this comment.
Don't forget to revert this later.
| const src = ref(''); | ||
| const audioElement = ref(); | ||
| const paused = ref(true); |
There was a problem hiding this comment.
Do you need this? You can access the paused value on the element itself to get its state. Same with volume.
There was a problem hiding this comment.
Yes we need this part: audioElement as ref don't trigger its "change" state when using media controls.
| import { ref, Ref, type Component, inject, onMounted, shallowRef } from 'vue'; | ||
| // eslint-disable-next-line max-len |
There was a problem hiding this comment.
Nop, use prettier to format the line.
| import { MsActionBar, MsActionBarButton, Translatable } from 'megashark-lib'; | ||
| import { PropType } from 'vue'; | ||
|
|
||
| interface FileViewerAction { |
There was a problem hiding this comment.
You'll probably want a disabled attribute to prevent clicking in some cases (max zoom level reached for example).
Also better to extract this interface to a separate file to be able to import it for typing.
There was a problem hiding this comment.
Since the action bar will change depending on the feature list we will make with Fabien on monday, I just add your suggestions as comment to keep it in mind in the next PR.
NicoTuxx
force-pushed
the
ms-file-viewer-bottombar
branch
3 times, most recently
from
0a2164a to
33b6167
Compare
- Create a FileViewerWrapper component to wrap the FileViewer and its action bar - Isolate the FileViewerActionBar as a common component - Update all the viewers component to use the new structure - Improve all viewers UI/UX - Add translation for 'opening file'
NicoTuxx
force-pushed
the
ms-file-viewer-bottombar
branch
from
33b6167 to
24e4998
Compare
No description provided.