Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MS] Updated the message for stats page when all orgs selected #8975

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[MS] Updated the message for stats page when all orgs selected #8975

merged 4 commits into from
Nov 22, 2024

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Nov 22, 2024

Closes #8971

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

@Max-7 Max-7 requested a review from a team as a code owner November 22, 2024 07:22
Ironicbay
Ironicbay requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@Ironicbay Ironicbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well fix this translation key
Capture d’écran 2024-11-22 à 10 50 32

client/src/locales/en-US.json Outdated Show resolved Hide resolved
client/src/locales/fr-FR.json Outdated Show resolved Hide resolved
@Max-7 Max-7 added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit 5f3021a Nov 22, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-client-stats-page branch November 22, 2024 11:13
vxgmichel pushed a commit that referenced this pull request Jan 17, 2025
@Max-7 @Ironicbay
Backport #8975 (#9364)
9184b25 
* [MS] Updated the message for stats page when all orgs selected

* [MS] Added style

* Apply suggestions from code review

Co-authored-by: Alban Costaz <[email protected]>

* [MS] Fixed pluralization

---------

Co-authored-by: fabienSvstr <[email protected]>
Co-authored-by: Alban Costaz <[email protected]>
@FirelightFlagboy FirelightFlagboy mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ironicbay Ironicbay Ironicbay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 | Bug]: Customer Area shows no stat when selecting all organizations
2 participants
@Max-7 @Ironicbay