Add data_dir option to command using a client
#9263
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d (PR #9089) - Force a shutdown after 10 seconds - Close the registered client connections when should_exit is registered - Handle ClientDisconnect error while reading the request body - Add a comment about the patching of the uvicorn server - Add newsfragment
* Update sign-latest-release.py Increase `per_page` parameter from 30 to 100 in the sign-latest-release script * Update signtool options to match the new SCILLE certificate * Add signtool to cspell custom words
This was done by creating a group `client_opts` in `clap_parser_with_shared_opts_builder` macro and generating a `ClientConfig` using the provided value. ## Other changes - `load_client_with_config` remove `config_dir` arg that is already present in `config` arg. - Remove the short option name for options defined by `clap_parser_with_shared_opts_builder`. - Remove `start_client`.
TODOs
|
|
This PR will first target master since it improve the base option provided in the cli to prevent forgetting updating some commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was done by creating a group
client_optsinclap_parser_with_shared_opts_buildermacro and generating aClientConfigusing the provided value.Other changes
load_client_with_configremoveconfig_dirarg that is already present inconfigarg.clap_parser_with_shared_opts_builder.start_client.