Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI commands for sequester and realm export #9343

Open
wants to merge 3 commits into
base: sequester-export-memory-only
Choose a base branch
from

Conversation

touilleMan
Copy link
Member

depends #9342

@touilleMan touilleMan requested review from a team as code owners January 14, 2025 11:22
@touilleMan touilleMan force-pushed the cli-sequester-and-realm-export branch from 1a5b2ad to 67a3aae Compare January 14, 2025 11:26
@FirelightFlagboy FirelightFlagboy changed the base branch from master to sequester-export-memory-only January 14, 2025 13:03
@FirelightFlagboy
Copy link
Contributor

I've changed the base so it's "simpler" to review

@touilleMan touilleMan force-pushed the sequester-export-memory-only branch from ec6ceb2 to e5ea163 Compare January 14, 2025 16:09
@touilleMan touilleMan force-pushed the cli-sequester-and-realm-export branch 2 times, most recently from 01cb078 to fd09197 Compare January 14, 2025 16:16
@touilleMan touilleMan force-pushed the sequester-export-memory-only branch from e5ea163 to 7d741e5 Compare January 14, 2025 20:51
@touilleMan touilleMan force-pushed the cli-sequester-and-realm-export branch from fd09197 to 67fd373 Compare January 14, 2025 20:52
Copy link
Contributor

@vxgmichel vxgmichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

logger.info("Backend configuration", **config.logging_kwargs())
if verbose:
logger.info("Parsec version", version=server_version)
logger.info("Backend configuration", **config.logging_kwargs())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird to conditionally enable logs instead of using a filtering rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants