Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Replaced workspaces by recent workspaces in sidebar #9345

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented Jan 14, 2025

Closes #9321

Remember which workspaces were added to the quick access list, and store the list so it stays when the app closes, when user logs out, or when switching org.
A workspace is added to the list when clicked on directly, or when accessed by a file link.

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes
  • Link any related issue in the description

@Max-7 Max-7 requested a review from a team as a code owner January 14, 2025 14:29
@Max-7 Max-7 force-pushed the ms-sidebar-workspaces-quick-access branch from e5f0a9e to 82fa7e6 Compare January 14, 2025 14:40
Copy link
Contributor

@Ironicbay Ironicbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The Recent workspaces list is not updated when accessing a favorite from the sidebar
  • The workspace order follows a "most recent" order when accessing workspaces, but the order is shuffled after relogging, and is not updated when visiting a workspace in the recent list. If the list displays Workspace 1 Workspace 2 Workspace 3 (1 being at the top and most recent), when visiting Workspace 3 I expect it to be bumped to the top of the list.

@Max-7 Max-7 force-pushed the ms-sidebar-workspaces-quick-access branch from bc2fec3 to fa5bf5e Compare January 15, 2025 12:29
@Max-7 Max-7 force-pushed the ms-sidebar-workspaces-quick-access branch from 42089d3 to a7eb155 Compare January 15, 2025 14:01
@Max-7 Max-7 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit a898df5 Jan 15, 2025
13 checks passed
@Max-7 Max-7 deleted the ms-sidebar-workspaces-quick-access branch January 15, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update sidebar with quick access
2 participants