Add keepalive absence detection in the client #9722
Merged
+216
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vxgmichel
force-pushed
the
issue-8359
branch
from
50d285d to
5248285
Compare
vxgmichel
force-pushed
the
issue-8359
branch
from
5248285 to
b626203
Compare
vxgmichel
force-pushed
the
issue-9614
branch
from
ca47a1e to
08ea78d
Compare
vxgmichel
force-pushed
the
issue-8359
branch
3 times, most recently
from
086772b to
ebdfa6a
Compare
touilleMan
approved these changes
Feb 15, 2025
libparsec/crates/serialization_format/src/protocol_python_bindings.rs
Outdated
Show resolved
Hide resolved
libparsec/crates/serialization_format/src/protocol_python_bindings.rs
Outdated
Show resolved
Hide resolved
libparsec/crates/protocol/schema/authenticated_cmds/events_listen.json5
Outdated
Show resolved
Hide resolved
vxgmichel
force-pushed
the
issue-8359
branch
4 times, most recently
from
66bf4e5 to
f7559fc
Compare
touilleMan
approved these changes
Feb 16, 2025
vxgmichel
force-pushed
the
issue-9614
branch
from
ce36831 to
bcc5046
Compare
…g for the connection
vxgmichel
force-pushed
the
issue-8359
branch
from
f7559fc to
ec238a0
Compare
vxgmichel
added a commit
that referenced
this pull request
Feb 16, 2025
* Make Offline error variants capture all connection errors * Remove Serialization variant to ConnectionError * Add error logs to AuthenticatedCmds::internal_send * Use error instead of warning for monitor crashing * Implement EventBus::wait_server_reconnect and use it in the monitors * Replace RejectedBySequesterService todos with internal errors * Better handling of StoreUnavailable * Add WorkspaceFdReadErrorStoreUnavailable to the bindings * Add newsfragment * Rename StoreUnavailable error variant to ServerBlockstoreUnavailable * Rename APIEvent::ServerConfig to APIEvent::OrganizationConfig * Add sse_keepalive to organization config event * Update SSE keepalive event * Add KeepaliveTracking struct * Add a test for APIEventOrganizationConfig.sse_keepalive python conversion * Fix connection loop continue in connection.rs * Add an info logs when retrying to connect to the SSE * Fix workspace_outbound_sync blocking the client stop when it's waiting for the connection * Use RequiredOption<NonZeroInteger> for sse_keepalive_seconds schema * Bump testbed server * Add newsfragment * Mark test_restart_partially_exported as flaky
vxgmichel
added a commit
that referenced
this pull request
Feb 17, 2025
vxgmichel
added a commit
that referenced
this pull request
Feb 17, 2025
vxgmichel
added a commit
that referenced
this pull request
Feb 18, 2025
vxgmichel
added a commit
that referenced
this pull request
Feb 18, 2025
vxgmichel
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8359