Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SimpleCachePlugin.kt): add error handling for failed calls #20

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

ShiinaKin
Copy link
Contributor

Add on(CallFailed) hook to handle and log failed calls, improving error management within the SimpleCachePlugin.

Close #19

Add `on(CallFailed)` hook to handle and log failed calls, improving
error management within the SimpleCachePlugin.
@Scogun
Copy link
Owner

Scogun commented Oct 14, 2024

Hello @ShiinaKin!

Thank you for the PR!
Please, increase the version and update the version in readme's.

Copy link
Owner

@Scogun Scogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase the version and update readmes

@ShiinaKin ShiinaKin requested a review from Scogun October 14, 2024 12:47
Copy link
Owner

@Scogun Scogun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarcloud bot commented Oct 14, 2024

@ShiinaKin ShiinaKin requested a review from Scogun October 14, 2024 13:08
@Scogun Scogun merged commit 3eecb41 into Scogun:main Oct 15, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deadlock due to unhandled CallFailed in SimpleCache
2 participants