Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nucleis: Add version 3.3.1 #6136

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Adamatt
Copy link

@Adamatt Adamatt commented Aug 25, 2024

Adding Nuclei

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

nucleis

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@Adamatt
Copy link
Author

Adamatt commented Aug 25, 2024

/verify

Adding this comment according to the documentation's step 7: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

nucleis

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Copy link
Contributor

@aliesbelik aliesbelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • No need to duplicate autoupdate.hash section.
  • Guess manifest should be renamed into nuclei.

Comment on lines +24 to +37
"architecture": {
"64bit": {
"url": "https://github.com/projectdiscovery/nuclei/releases/latest/download/nuclei_$version_windows_amd64.zip",
"hash": {
"url": "$baseurl/nuclei_$version_checksums.txt"
}
},
"32bit": {
"url": "https://github.com/projectdiscovery/nuclei/releases/latest/download/nuclei_$version_windows_386.zip",
"hash": {
"url": "$baseurl/nuclei_$version_checksums.txt"
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"architecture": {
"64bit": {
"url": "https://github.com/projectdiscovery/nuclei/releases/latest/download/nuclei_$version_windows_amd64.zip",
"hash": {
"url": "$baseurl/nuclei_$version_checksums.txt"
}
},
"32bit": {
"url": "https://github.com/projectdiscovery/nuclei/releases/latest/download/nuclei_$version_windows_386.zip",
"hash": {
"url": "$baseurl/nuclei_$version_checksums.txt"
}
}
}
"architecture": {
"64bit": {
"url": "https://github.com/projectdiscovery/nuclei/releases/latest/download/nuclei_$version_windows_amd64.zip"
},
"32bit": {
"url": "https://github.com/projectdiscovery/nuclei/releases/latest/download/nuclei_$version_windows_386.zip"
}
},
"hash": {
"url": "$baseurl/nuclei_$version_checksums.txt"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants