feat: subgraph handling #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyghayrat
reviewed
Aug 1, 2024
| async function getAnnouncementsUsingSubgraph({ | ||
| subgraphUrl, | ||
| filter = '', | ||
| pageSize = 1000 |
There was a problem hiding this comment.
I believe alchemy supports page size of 10k.
There was a problem hiding this comment.
But maybe it's better to just leave it at 1K, and just make a note of it. Because other subgraph providers usually only support 1k.
There was a problem hiding this comment.
cool updated with docs:
garyghayrat
reviewed
Aug 1, 2024
| entity: string; | ||
| lastId?: string; | ||
| }): AsyncGenerator<T[], void, unknown> { | ||
| const variables: { first: number; id_lt?: string } = { |
There was a problem hiding this comment.
More documentation in this file would really help
marcomariscal
force-pushed
the
feat/subgraph-handling
branch
from
508a4a8
to
35a3e3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for fetching announcements via a subgraph.