correct ordering algorithm

ScotterC · Oct 21, 2013 · 31b7317 · 31b7317
1 parent 29c8d2e
commit 31b7317
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/concern/positionable.rb b/lib/concern/positionable.rb
@@ -9,6 +9,12 @@ module Positionable
     end
 
     def move_to(position)
+
+      self.exec_sql "
+      UPDATE #{self.class.table_name}
+      SET position = position - 1
+      WHERE position > :position AND position > 0", {position: self.position}
+
       self.exec_sql "
       UPDATE #{self.class.table_name}
       SET position = :position

diff --git a/spec/components/concern/positionable_spec.rb b/spec/components/concern/positionable_spec.rb
@@ -34,11 +34,13 @@ class TestItem < ActiveRecord::Base
       positions.should == [3,0,1,2,4]
       TestItem.pluck(:position).sort.should == [0,1,2,3,4]
 
+      TestItem.find(3).move_to(1)
+      positions.should == [0,3,1,2,4]
 
       # this is somewhat odd, but when there is not positioning
       # not much we can do
       TestItem.find(1).move_to(5)
-      positions.should == [3,0,2,4,1]
+      positions.should == [0,3,2,4,1]
 
       TestItem.pluck(:position).sort.should == [0,1,2,3,4]