omit single quotes from slug

ScotterC · Jun 2, 2013 · da22c0f · da22c0f
1 parent 1833c12
commit da22c0f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/lib/slug.rb b/lib/slug.rb
@@ -1,12 +1,10 @@
 # encoding: utf-8
 
-# Generates a slug. This is annoying because it's duplicating what the javascript
-# does, but on the other hand slugs are never matched so it's okay if they differ
-# a little.
 module Slug
 
   def self.for(string)
-    slug = string.parameterize.gsub("_", "-")
+    slug = string.gsub("'", "").parameterize
+    slug.gsub!("_", "-")
     slug =~ /[^\d]/ ? slug : '' # Reject slugs that only contain numbers, because they would be indistinguishable from id's.
   end
 

diff --git a/spec/components/slug_spec.rb b/spec/components/slug_spec.rb
@@ -51,5 +51,9 @@
     Slug.for('電車男 2').should be_blank
   end
 
+  it "doesn't keep single quotes within word" do
+    Slug.for("Jeff hate's this").should == "jeff-hates-this"
+  end
+
 end