RFC-0005 Phase 2, annotated string functions and added tests. #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
StringFunctions
class, withScalarFunctionConstantStats
andScalarPropagateSourceStats
.Motivation and Context
https://github.com/prestodb/rfcs/blob/main/RFC-0005-functions-stats.md
Impact
None unless the user chooses to enable the feature via setting the session/feature flag.
A new session flag, scalar_function_stats_propagation_enabled and a new feature config will be introduced i.e. optimizer.scalar-function-stats-propagation-enabled, by setting this session flag or feature flag, this feature can be turned on or off.
When the feature is enabled, since string functions are annotated the effect of stats propagation can be measured or seen in the form of plan changes.
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.